This repository has been archived by the owner on Oct 30, 2021. It is now read-only.
split into multiple files [wip] #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ansis if possible, yeah. Let's reevaluate next week. |
|
When we move on this, let's also split into pure C++ headers (that don't have any node.js/nan dependencies) and the binding code. This will allow us to do something I feel is important for good test coverage with bad data: write C++ unit tests against the C++ headers directly. |
yhahn
force-pushed
the
master
branch
2 times, most recently
from
33b636a to
26b48c1
Compare
|
Done in #116 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started splitting the cache into multiple smaller files but then I realized that now might not be the best time with all the in-progress trie/degenless/strings-attached work. @apendleton I should pause this until those get merged, right?