Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uglify-js should be a dependency, not a devDependency #800

Closed
davidtheclark opened this issue Jun 27, 2017 · 0 comments
Closed

uglify-js should be a dependency, not a devDependency #800

davidtheclark opened this issue Jun 27, 2017 · 0 comments
Assignees
@davidtheclark
Labels
bug

Comments

@davidtheclark
Copy link
Contributor

It is used in the custom build process, so needs to be a dependency:

assembly/scripts/build-js.js

Line 7 in 60f541d

const UglifyJS = require('uglify-js');

@davidtheclark davidtheclark self-assigned this Jun 29, 2017
davidtheclark pushed a commit that referenced this issue Jun 29, 2017
Make uglify-js a real dependency
9bf2f79 
Closes #800.
@davidtheclark davidtheclark mentioned this issue Jun 29, 2017
Merged
davidtheclark pushed a commit that referenced this issue Jul 2, 2017
Make uglify-js a real dependency
5056f87 
Closes #800.
samanpwbb added a commit that referenced this issue Jul 5, 2017
@samanpwbb
v0.14.0 (#814)
9b2d5e5 
* adjust icon sizing, add icon-wrapper class, closes #763

* rename icon-wrapper to icon-inliner, other small fixes

* force txt-bold to be 1em line height, fixes line height offsets, closes #775

* rework size scale, closes #749

* Add limiter class, consistify scale even more

* only single-declaration utility classes should have important (#785)

* New copy of Open Sans (#786)

Reverts prior line-height change to bold weight.

Closes #775.

* reset abbr text-decoration, fixes txt-abbr rule (#788)

* Weight loss program (#787)

See changes in changelog.md

* Lighten gray-faint and add a line of caution to color documentation

* Reintroduce darken5 and lighten5 for backgrounds only

* Add icons option to build script (#794)

options.icons is an array of icon names. If this option is used, only icon names that match options.icons will be included in Assembly. Closes #782

* adds color and hover state to prose links (#798)

* Make uglify-js a real dependency

Closes #800.

* add unprose class, closes #793 (#795)

* add select--xs class to match btn--xs (#811)

* fix spin animation utility (#812)

closes #790

* prepare v0.14.0 (#813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidtheclark davidtheclark

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidtheclark