Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/reduce color variations from some form component classes #746

Closed
samanpwbb opened this issue Mar 4, 2017 · 2 comments
Closed

Remove/reduce color variations from some form component classes #746

samanpwbb opened this issue Mar 4, 2017 · 2 comments
Assignees
Milestone

Comments

@samanpwbb
Copy link
Contributor

samanpwbb commented Mar 4, 2017

In our experience with assembly so far, for some form elements, color variations have never been used. Therefore, they should not be included in the CSS by default. Right now, Assembly uses the interactive-color variables to set colors for these inputs by default, and we would rely on these variables alone to color form elements.

We should definitely remove variations from .checkbox, .radio, .range, and .switch.

For .button, .link, .toggle, and .select, we should either preserve all variations, or pick a few.

A few questions:

  • Should we completely remove the code that makes it possible to generate variations for these elements, or should we just remove the variations by default?

  • Could we think of a different approach to colors that is more minimal, but allows for more than one variation? One option would be to have, say, four options: primary-interactive (blue), secondary-interactive (gray), primary-interactive-inverted (white), secondary-interactive-inverted (rgba(255,255,255,.5). I do think having at least a regular and then inverted option would be useful.

  • Would users want the flexibility to set a different interactive-color for each input? We could have range-color, checkbox-color, ect. variables instead of a shared interactive-color variable?

@samanpwbb samanpwbb modified the milestone: 1.0 Mar 28, 2017
@samanpwbb
Copy link
Contributor Author

@mapbox/design @mapbox/studio @tristen ect – I want to start working on this next week. With this issue plus #752 how do folks feel about dropping the current color naming convention and switching entirely to 'semantic' color names (primary, secondary, warning, background, ect)?

@samanpwbb
Copy link
Contributor Author

closed by #787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant