-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2 new Markdown IT Functionality (include and container) #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awesome! I've been looking for a convenient way to include other .md files and to apply CSS classes for long, tbh.
Before we can get started w/ merging this PR, please take note of the comments I've made and change your code appropriately.
In order to have your code checked correctly, you'll have to fix your code.
I assume the error that the CI is facing is caused by the package-lock.json
file being generated using an npm
version which is lower than v7.
Please perform following steps in order to fix it:
- Revert changes made to
package-lock.json
:git checkout origin/dev -- package-lock.json
- Install npm v7 (or higher - you might have to install a more recent version of nodejs in order to do so)
- Re-run
npm install
For a next time you might want to keep seperate features truly separate (i.e. create a separate PR for the CSS feature and a separate PR for the Include feature).
It's okay, though - we'll leave it as is for now.
Thanks a lot for the effort you put into this, I really appreciate it ✨
Thank a lot by the way to take the time to describe them all like this, it's really appreciated. Once I did all you're recommandations, I update npm and nodejs to latests versions I had this error, Locally: I was able to fix it using |
@L3houx for some reason I don't know, the Drone CI build didn't start. Thanks for taking care 😄 |
Hi @manuth, I fixed the I will push my modifications soon. |
Oh I'm sorry - I totally forgot about that. |
@L3houx running the tests failed.
However - I wanted to change how detecting the root works anyways. |
It's all good for me, I will wait your commit to use it in the markdown-it-include extension configuration |
@L3houx the CI tests will still fail As this issue is unrelated to this very PR is ready to go. Let me know if you are ready to have this PR merged or if you have something more to add. |
It's all good for me :) You can press the merge button 😎 |
Alright - did so! Thanks for your contribution, I really appreciate it 😄 |
Thank You and Have a nice one!