[Dashboard] fix: RouteStatus is not nullchecked

manusa · Dec 29, 2020 · e9a4e19 · e9a4e19
1 parent 9fdc490
commit e9a4e19
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/...b/openshift/api/route/v1/RouteStatus.java → ...b/openshift/api/route/v1/RouteStatus.java b/...b/openshift/api/route/v1/RouteStatus.java → ...b/openshift/api/route/v1/RouteStatus.java
@@ -27,6 +27,16 @@
 import lombok.Singular;
 import lombok.ToString;
 
+/*
+ *
+ *
+ * FILE OVERRIDDEN DUE TO BAD DESCRIPTION FOR ingress FIELD:
+ * - It can come as null, but it's marked as required.
+ *
+ *
+ *
+ */
+
 /**
  * RouteStatus provides relevant info about the status of a route, including which routers acknowledge it.
  */
@@ -42,7 +52,6 @@ public class RouteStatus implements Model {
   /**
    * ingress describes the places where the route may be exposed. The list of ingress points may contain duplicate Host or RouterName values. Routes are considered live once they are `Ready`
    */
-  @NonNull
   @JsonProperty("ingress")
   @Singular(value = "addToIngress", ignoreNullCollections = true)
   private List<RouteIngress> ingress;

diff --git a/buildSrc/src/main/java/com/marcnuri/yack/schema/model/ModelGenerator.java b/buildSrc/src/main/java/com/marcnuri/yack/schema/model/ModelGenerator.java
@@ -95,7 +95,7 @@ void generate() {
           final String fileContents = modelTemplate.execute(templateContext);
           writeFile(key, fileContents);
         });
-    settings.getLogger().lifecycle("Generated {} api entries", schemas.size());
+    settings.getLogger().lifecycle("Generated {} model entries", schemas.size());
   }
 
   private Map<String, Object> templateContext(Entry<String, Schema> entry) {