check data before append html

manuelson · Oct 5, 2017 · c17b3eb · c17b3eb
1 parent 154dd01
commit c17b3eb
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/app/code/Magento/Search/view/frontend/web/form-mini.js b/app/code/Magento/Search/view/frontend/web/form-mini.js
@@ -286,16 +286,17 @@ define([
                 $.getJSON(this.options.url, {
                     q: value
                 }, $.proxy(function (data) {
-                    $.each(data, function (index, element) {
-                        var html;
-                        element.index = index;
-                        html = template({
-                            data: element
+                    if (data.length) {
+                        $.each(data, function (index, element) {
+                            var html;
+
+                            element.index = index;
+                            html = template({
+                                data: element
+                            });
+                            dropdown.append(html);
                         });
-                        dropdown.append(html);
-                    });
 
-                    if (dropdown.has('li').length) {
                         this.responseList.indexList = this.autoComplete.html(dropdown)
                             .css(clonePosition)
                             .show()
@@ -322,7 +323,8 @@ define([
                                 this.element.attr('aria-activedescendant', $(e.target).attr('id'));
                             }.bind(this))
                             .on('mouseout', function (e) {
-                                if (!this._getLastElement() && this._getLastElement().hasClass(this.options.selectClass)) {
+                                if (!this._getLastElement() &&
+                                    this._getLastElement().hasClass(this.options.selectClass)) {
                                     $(e.target).removeClass(this.options.selectClass);
                                     this._resetResponseList(false);
                                 }