Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow::find_cnodes not working with cron #58

Open
jfrioux opened this issue Dec 3, 2020 · 1 comment
Open

Workflow::find_cnodes not working with cron #58

jfrioux opened this issue Dec 3, 2020 · 1 comment

Comments

@jfrioux
Copy link
Member

jfrioux commented Dec 3, 2020

When testing cron

sequence 
   cron '*/5 * * * *'
    bob _

Receiving an error in app/models/floristry/workflow.rb:202:in find_cnodes`

Execution is started with no errors in Flack.

Needs further investigation.

jfrioux added a commit to jfrioux/floristry that referenced this issue Dec 6, 2020
Schedules are a type of banch procedure with atts, thus extracting this to the parent class Procecure made sense

Related to mantor#58
@jfrioux
Copy link
Member Author

jfrioux commented Dec 7, 2020

Documenting progress.

Brought some changes on my fork that handle the partial(s) rendering.

Thought, it seems that we made some assumptions around the cron|schedule|every that don't hold:
1st - Can't be encapsulated in a sequence, as it seems to expect it will be the top unit. Having a sequence with a nested cron will terminate and the cron won't behave as we'd expect.
2nd - That being out of the way, nids in a cron don't follow the same pattern, as each runs stays attached to the same node. For example, I launched a task with a cron that runs at every minute, here's how nids look like (at Trail.insert_in_tree(tree, nid, payload):

["0", "1", "1-90"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant