Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

New distributive packages #1268

Merged
merged 8 commits into from
Mar 21, 2016
Merged

New distributive packages #1268

merged 8 commits into from
Mar 21, 2016

Conversation

langston-barrett
Copy link
Contributor

  • Installs cleanly on a fresh build of most recent master branch
  • Upgrades cleanly from the most recent release
  • Updates documentation relevant to the changes

Upgrade to new packaging system, which will make fixing broken checks a vastly faster process.
Removes duplicated code from back when I didn't know how to Ansible.
Fixes #1259

The dnsmasq checks are failing on this because of #1265

@langston-barrett langston-barrett mentioned this pull request Mar 11, 2016
4 tasks
@langston-barrett
Copy link
Contributor Author

This will be ready as soon as mantl/mantl-packaging#56 is merged. This has been tested on DO, Vagrant.

@ryane
Copy link
Contributor

ryane commented Mar 15, 2016

it looks like mantl/mantl-packaging#56 has been merged but I'm still seeing broken distributive checks (upgrade from 1.0.3 on aws):

time="2016-03-15T14:21:28Z" level=info msg="Report from checklist" checklist="dnsmasq health check" report="↴\nTotal: 8\nPassed: 7\nFailed: 1\nOther: 0\nIs not a file: /etc/resolv.conf" 

@langston-barrett
Copy link
Contributor Author

@ryane The CI build is broken on mantl-packaging, and so didn't publish the new version of that RPM. I'll do so manually soon.

@langston-barrett
Copy link
Contributor Author

Actually, it looks like it has been uploaded. I'll do some digging soon.

@ryane
Copy link
Contributor

ryane commented Mar 15, 2016

@siddharthist I just revisited this. I noticed a couple of things. First, the distributive package itself is not being upgraded. After applying this pr on 1.0.3, I end up with:

distributive.x86_64 0.2.4-1

On a fresh build, I end up with:

distributive.x86_64 0.2.5-1

Also, all of the distributive* files in /etc/consul are still present post-upgrade so that also generates a bunch of failed checks.

@langston-barrett
Copy link
Contributor Author

@ryane Thanks for checking, I think that change should fix the issue with the distributive package being upgraded. As for deregistering checks, do you have any suggestions? We could just make an upgrade ansible playbook, but that's kinda messy.

@@ -15,7 +15,7 @@
- name: install distributive, health check packages for current role
become: yes
yum:
state: present
state: latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do latest, though, aren't we opening ourselves up for problems down the road if we release a new version of distributive that is incompatible with this release? this is what happened with mantl-dns in #1265. Can we just explicitly tell it to install 0.2.5-1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were having that discussion in Slack the other day. That's my preferred option, I'll make it so.

@ryane
Copy link
Contributor

ryane commented Mar 15, 2016

yeah, it is messy. we do already have a precedent of upgrade logic in playbooks: https://github.com/CiscoCloud/mantl/blob/master/roles/zookeeper/tasks/main.yml#L33. It's not ideal but not sure how to get around it in this case.

@langston-barrett langston-barrett force-pushed the feature/new-distributive-packages branch from 6db9f68 to 006ddc1 Compare March 16, 2016 19:16
@langston-barrett
Copy link
Contributor Author

All the versions are now pinned to avoid pain later. I'll work on an upgrade playbook.

- consul
- distributive
- docker

# Needed for upgrade from Mantl <1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super minor but it is actually needed for upgrading mantl 1.0.x to 1.1

@ryane
Copy link
Contributor

ryane commented Mar 18, 2016

@siddharthist do you think we should merge this as-is and then create a new issue to track the upgrade to 1.1? It would be good to get master fixed

@ryane
Copy link
Contributor

ryane commented Mar 21, 2016

this fixes new builds but upgrades are still a problem. tracking in #1288

ryane added a commit that referenced this pull request Mar 21, 2016
@ryane ryane merged commit f3924c3 into master Mar 21, 2016
@ryane ryane deleted the feature/new-distributive-packages branch March 21, 2016 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distributive symlink failures
2 participants