-
Notifications
You must be signed in to change notification settings - Fork 414
Conversation
This will be ready as soon as mantl/mantl-packaging#56 is merged. This has been tested on DO, Vagrant. |
it looks like mantl/mantl-packaging#56 has been merged but I'm still seeing broken distributive checks (upgrade from 1.0.3 on aws):
|
@ryane The CI build is broken on mantl-packaging, and so didn't publish the new version of that RPM. I'll do so manually soon. |
Actually, it looks like it has been uploaded. I'll do some digging soon. |
@siddharthist I just revisited this. I noticed a couple of things. First, the distributive package itself is not being upgraded. After applying this pr on 1.0.3, I end up with:
On a fresh build, I end up with:
Also, all of the |
@ryane Thanks for checking, I think that change should fix the issue with the distributive package being upgraded. As for deregistering checks, do you have any suggestions? We could just make an upgrade ansible playbook, but that's kinda messy. |
@@ -15,7 +15,7 @@ | |||
- name: install distributive, health check packages for current role | |||
become: yes | |||
yum: | |||
state: present | |||
state: latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we do latest
, though, aren't we opening ourselves up for problems down the road if we release a new version of distributive that is incompatible with this release? this is what happened with mantl-dns in #1265. Can we just explicitly tell it to install 0.2.5-1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were having that discussion in Slack the other day. That's my preferred option, I'll make it so.
yeah, it is messy. we do already have a precedent of upgrade logic in playbooks: https://github.com/CiscoCloud/mantl/blob/master/roles/zookeeper/tasks/main.yml#L33. It's not ideal but not sure how to get around it in this case. |
Fixes #935 Remove extraneous distributive check configs Tie distributive checks to services when applicable Remove hard version requirement for distributive Don't tie distributive check to consul service
6db9f68
to
006ddc1
Compare
All the versions are now pinned to avoid pain later. I'll work on an upgrade playbook. |
- consul | ||
- distributive | ||
- docker | ||
|
||
# Needed for upgrade from Mantl <1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super minor but it is actually needed for upgrading mantl 1.0.x to 1.1
@siddharthist do you think we should merge this as-is and then create a new issue to track the upgrade to 1.1? It would be good to get master fixed |
this fixes new builds but upgrades are still a problem. tracking in #1288 |
…kages New distributive packages
Upgrade to new packaging system, which will make fixing broken checks a vastly faster process.
Removes duplicated code from back when I didn't know how to Ansible.
Fixes #1259
The dnsmasq checks are failing on this because of #1265