Migration to bitbucket api v2

[Xen3r0]

Bitbucket api v1 has been removed, so migration to v2 is required.

https://developer.atlassian.com/cloud/bitbucket/deprecation-notice-v1-apis/?_ga=2.77091549.917431349.1565616116-336821238.1559654052

[dregad]

I just tried a quick test and it failed to import anything. I tried both with master and * in branches repo config,

I don't have time to investigate further right now, but please have a look at the inline comments below.

Also, I would suggest since API 1.0 is gone, to remove protected $api_url_10 (line 18). And since there is only one API being used, it may be worth getting rid of the _20 suffixes.

Finally, I noted some whitespace issues in the GitHub diffs, most likely because you indented with spaces instead of tabs.

[Xen3r0]

Can you review again ?

[dregad]

Thanks for the update.

As far as I can tell, both full and latest import functions works fine now, both with all (*) and comma-delimited list of branches.

I did not test integration with webhook to process commits though.

[semanticfire]

I've tested the PR in a full integration situation, bitbucket commit initializing a mantis update, both * and comma separated lists work as expected

[dregad]

Awesome, many thanks for taking the time to test !