Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LabelList instead of BarLabel, and add valueLabelProps option support. #7160

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Use LabelList instead of BarLabel, and add valueLabelProps option support. #7160

merged 3 commits into from
Nov 24, 2024

Conversation

minosss
Copy link
Contributor

@minosss minosss commented Nov 23, 2024

LabelList can display labels more easily. Fix #7156

Before

Screenshot 2024-11-23 at 17 34 14

After

Screenshot 2024-11-23 at 17 17 15

orientation="vertical" label uses default color

Screenshot 2024-11-23 at 17 17 03

pass label props valueLabelProps={{ position: 'inside', fill: 'white' }}

Screenshot 2024-11-23 at 17 17 31

@rtivital
Copy link
Member

Please fix errors

@rtivital rtivital merged commit 931565c into mantinedev:master Nov 24, 2024
1 check passed
@rtivital
Copy link
Member

Thanks!

@namakshenas namakshenas mentioned this pull request Nov 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

withBarValueLabel value not displaying in correct positions
2 participants
@minosss @rtivital