withBarValueLabel not displaying in correct positions in BarChart - Issue #6991 #7011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
CI is failing because of prettier. you should run |
|
Yes, I ran that command already. |
Kenzo-Wada
reviewed
Oct 23, 2024
Comment on lines
+134
to
+143
| function labelCoordinates(): { dx: number, dy: number } { | ||
| let coord: { dx: number, dy: number } = { dx: 0, dy: 0 } | ||
| if (others.props.h < 300) { | ||
| coord = { ...coord, dx: Math.ceil(others?.width + 10) } | ||
| } else { | ||
| coord.dx = Math.ceil(others?.width - others?.viewBox?.x / 2) | ||
| } | ||
| coord = { ...coord, dy: Math.ceil(others.props.h / 15) } | ||
| return coord; | ||
| } |
There was a problem hiding this comment.
IMO: I think this way is much simple, WDYT? I prefer not using let in this case.
Suggested change
| function labelCoordinates(): { dx: number, dy: number } { | |
| let coord: { dx: number, dy: number } = { dx: 0, dy: 0 } | |
| if (others.props.h < 300) { | |
| coord = { ...coord, dx: Math.ceil(others?.width + 10) } | |
| } else { | |
| coord.dx = Math.ceil(others?.width - others?.viewBox?.x / 2) | |
| } | |
| coord = { ...coord, dy: Math.ceil(others.props.h / 15) } | |
| return coord; | |
| } | |
| function labelCoordinates(): { dx: number, dy: number } { | |
| return { | |
| dx: others.props.h < 300 | |
| ? Math.ceil(others?.width + 10) | |
| : Math.ceil(others?.width - others?.viewBox?.x / 2), | |
| dy: Math.ceil(others.props.h / 15) | |
| }; | |
| } |
There was a problem hiding this comment.
That looks good too.
I tried not to use ternary operators just in case we need to add more conditions in future.
There was a problem hiding this comment.
Since the code is not complicated yet, I think we should consider it only when additional conditions arise!
|
you're sure?? plz have a look at this, which ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function that determines "dy" and "dx" parameters of the label depending on height and width of the Bar Chart.