Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core]: add ChromeOS to useOS #6541

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Kenzo-Wada
Copy link
Contributor

What

add chromeos to useOS

Why

I realized that useOS returns undetermined on ChromeOS.

@rtivital
Copy link
Member

It is a breaking change, cannot be merged until 8.0 release. Changes of OS type may introduce unexpected errors, for example, when it is used as a key of a record: type OSLabels = Record<OS, ReactNode>.

@Kenzo-Wada
Copy link
Contributor Author

@rtivital

I see, should I close this PR for now? or is it ok to keep here opened until next major release?

@rtivital
Copy link
Member

Let's keep it open

@rtivital rtivital added the Deferred PR that is not planned to be merged until next major version label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deferred PR that is not planned to be merged until next major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants