Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Add tests for <FocusTrap /> using shift + tab #4969

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Devon-Dickson
Copy link
Contributor

Fixes the tests that blocked #4679, and #4856 was merged without. Ended up being a silly thing that blocked my PR for weeks 🙄 .

Unfortunately, useFocusTrap has a setTimeout before actually focusing on an element, so we need to add a wait() before each of these assertions. These two test cases will add about 60ms to the total run time of the test suite, so I'll leave it up to @rtivital to decide on their worth.

@rtivital rtivital merged commit 203b602 into mantinedev:master Oct 12, 2023
1 check passed
@rtivital
Copy link
Member

Thanks!

@Devon-Dickson Devon-Dickson deleted the tests/focusTrap branch October 12, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants