Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve missing addon warning #49

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

bertdeblock
Copy link
Contributor

PR #45 introduced an in-repo addon for testing purposes, but because the in-repo addon isn't published, Ember CLI displays a warning because the lib/baz path is still included in the published package.json file.

This PR switches to using ember-cli-app-version instead of the custom in-repo addon.
Different addon, but we still test the same functionality.

Resolves #45 (comment).

Copy link
Owner

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks for doing this for me! I was about to get stuck in and publish the in-repo add-on separately to fix the warning. Good idea using an existing addon with similar functionality 👍

@mansona mansona merged commit 1bee9ca into mansona:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants