Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum supported Node.js version to v16 (No longer relevant) #362

Merged
merged 2 commits into from
May 23, 2023
Merged

Update minimum supported Node.js version to v16 (No longer relevant) #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a4575d
Update minimum supported Node.js version to v14
Turbo87 May 23, 2023
047263d
drop support for Node v14
mansona May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,19 @@ on:

env:
FORCE_COLOR: 1
NODE_VERSION: 16.x

jobs:
lint:
name: Linting
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12.x
- run: npm i -g npm@7
node-version: ${{ env.NODE_VERSION }}
cache: npm
- run: npm ci
- run: npm run lint:hbs
- run: npm run lint:js
Expand All @@ -31,12 +32,12 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: mansona/npm-lockfile-version@v1
- uses: actions/setup-node@v2
- uses: actions/setup-node@v3
with:
node-version: 12.x
- run: npm i -g npm@7
node-version: ${{ env.NODE_VERSION }}
cache: npm
- run: npm ci
- run: npm run test:ember

Expand All @@ -45,11 +46,11 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12.x
- run: npm i -g npm@7
node-version: ${{ env.NODE_VERSION }}
cache: npm
- run: npm install --no-package-lock
- run: npm run test:ember

Expand All @@ -76,11 +77,11 @@ jobs:
- ember-release-no-deprecations

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12.x
- run: npm i -g npm@7
node-version: ${{ env.NODE_VERSION }}
cache: npm
- run: npm ci

- name: test
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"webpack": "^5.62.0"
},
"engines": {
"node": ">= 12"
"node": ">= 16"
},
"ember": {
"edition": "octane"
Expand Down