fix(finance): fix DiUS#767

manosbatsis · Oct 27, 2023 · 4b9eb65 · 4b9eb65
1 parent a8b8ff0
commit 4b9eb65
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/src/main/java/com/github/javafaker/Finance.java b/src/main/java/com/github/javafaker/Finance.java
@@ -3,10 +3,7 @@
 import org.apache.commons.lang3.StringUtils;
 
 import java.math.BigInteger;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
 
 public class Finance {
     private final Faker faker;
@@ -66,6 +63,11 @@ public String iban(String countryCode) {
         return countryCode + checkSum + basicBankAccountNumber;
     }
 
+    /** Get the set of country codes supported for IBAN generation */
+    public Set<String> ibanCountryCodes() {
+        return countryCodeToBasicBankAccountNumberPattern.keySet();
+    }
+
     private CreditCardType randomCreditCardType() {
         return CreditCardType.values()[this.faker.random().nextInt(CreditCardType.values().length)];
     }

diff --git a/src/test/java/com/github/javafaker/FinanceTest.java b/src/test/java/com/github/javafaker/FinanceTest.java
@@ -3,8 +3,10 @@
 import org.apache.commons.validator.routines.checkdigit.LuhnCheckDigit;
 import org.junit.Test;
 
+import java.util.Set;
+
 import static com.github.javafaker.matchers.MatchesRegularExpression.matchesRegularExpression;
-import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.*;
 import static org.junit.Assert.assertThat;
 
 public class FinanceTest extends AbstractFakerTest {
@@ -37,6 +39,19 @@ public void ibanWithCountryCode() {
         assertThat(faker.finance().iban("DE"), matchesRegularExpression("DE\\d{20}"));
     }
 
+    @Test
+    public void ibanWithAllCountryCodes() {
+        Set<String> ibanCountryCodes = faker.finance().ibanCountryCodes();
+        for (String countryCode : ibanCountryCodes) {
+            assertThat(
+                    "IBAN for " + countryCode + " must not be null or empty",
+                    faker.finance().iban(countryCode),
+                    not(isEmptyString())
+            );
+        }
+        assertThat(faker.finance().iban("DE"), matchesRegularExpression("DE\\d{20}"));
+    }
+
     @Test
     public void creditCardWithType() {
         for(CreditCardType type : CreditCardType.values()) {