Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable filenames #115

Merged
merged 5 commits into from
Feb 25, 2022
Merged

configurable filenames #115

merged 5 commits into from
Feb 25, 2022

Conversation

manolomartinez
Copy link
Owner

  • Documenting the new feature
  • Read the new config option 'downloaded_filename' and use it to construct the fullpath
  • It's filename that we care about now, not placeholders.filename
  • substitute should be a method of Placeholders
  • Use the new Placeholders.substitute() method

@manolomartinez manolomartinez linked an issue Sep 5, 2021 that may be closed by this pull request
@Simon818
Copy link

Simon818 commented Jan 1, 2022

Getting back to this after some time. I think this looks great. One nice touch would be to add a {file_extension} placeholder that pulls the extension off placeholders.filename. This allows defining a download filename without having to manually add the extension to the end. It is also theoretically possible for podcasts to have files with multiple extensions, so in this case any custom filename that hardcodes the extension is not going to work. I realize this is a bit of a hack, so thoughts are welcome.

@manolomartinez manolomartinez merged commit 224fc50 into master Feb 25, 2022
@manolomartinez manolomartinez deleted the configurable_filenames branch February 25, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: configurable filenames
2 participants