-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
albumart #106
Open
manolomartinez
wants to merge
9
commits into
master
Choose a base branch
from
albumart
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
albumart #106
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6c5024d
This is what I want to do
manolomartinez a3cec45
A first attempt at implementing a coverart feature
manolomartinez d0210c1
cover art is tagging
manolomartinez ebd3a3e
filename and mimetype of the cover image, spaghetti-ly
manolomartinez 943fc2d
Eyed3 expects bytes
manolomartinez 25d1748
Check if the file exists
manolomartinez 8e530b0
Update greg/data/greg.conf
manolomartinez 7acd0dd
merging master
manolomartinez ef838b4
Merge branch 'master' into albumart
manolomartinez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
merging master
- Loading branch information
commit 7acd0dd5efa4b9faf9ce99bf32e73294b5ae6982
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be cool if the
coverart_filename
could be a http(s) URL. And if the images linked from the feed (e.g.<image><url>
in the feed and<itunes:image>
in the article) would be made available as placeholders. This way we could do:or
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, let me look into that.