Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

albumart #106

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Prev Previous commit
Next Next commit
merging master
  • Loading branch information
manolomartinez committed Jun 16, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 7acd0dd5efa4b9faf9ce99bf32e73294b5ae6982
7 changes: 5 additions & 2 deletions greg/aux_functions.py
Original file line number Diff line number Diff line change
@@ -211,12 +211,15 @@ def tag(placeholders):
if file_to_tag.tag == None:
file_to_tag.initTag()
for mytag in tagdict:
setattr(file_to_tag.tag, mytag, tagdict[mytag])
if isinstance(getattr(file_to_tag.tag, mytag), eyed3.id3.tag.DltAccessor):
getattr(file_to_tag.tag, mytag).set(tagdict[mytag])
else:
setattr(file_to_tag.tag, mytag, tagdict[mytag])
if coverart:
with open(coverart_filename, 'rb') as imagefile:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool if the coverart_filename could be a http(s) URL. And if the images linked from the feed (e.g. <image><url> in the feed and <itunes:image> in the article) would be made available as placeholders. This way we could do:

coverart = {articleimage}

or

coverart = {feedimage}

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, let me look into that.

image = imagefile.read()
file_to_tag.tag.images.set(
type_=3, img_data=image, mime_type=coverart_mime)
type_=3, img_data=image, mime_type=coverart_mime)
file_to_tag.tag.save()


You are viewing a condensed version of this merge commit. You can view the full changes here.