Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip fixes #211

Merged
merged 13 commits into from
Jan 31, 2020
Merged

Pip fixes #211

merged 13 commits into from
Jan 31, 2020

Conversation

manodeep
Copy link
Owner

Still fixing #208

@manodeep manodeep added this to the v2.3.3 milestone Jan 30, 2020
@manodeep
Copy link
Owner Author

Huh - weird! I would have thought that the #209 would have already accounted for the initial commits on this branch.

@pep8speaks
Copy link

pep8speaks commented Jan 30, 2020

Hello @manodeep! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-30 20:09:51 UTC

@lgarrison
Copy link
Collaborator

Weird about the commits, maybe because we're "reusing" the same branch as the first PR?

@manodeep
Copy link
Owner Author

@lgarrison Thanks for fixing up the PR. Since the common.mk file has to be read in first any replacements, I moved the this_python substitution back down to after the python validation (i.e., where that section was previously)

@manodeep
Copy link
Owner Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

Complexity decreasing per file
==============================
+ setup.py  -3
         

See the complete overview on Codacy

@manodeep
Copy link
Owner Author

@lgarrison Is this okay to merge?

(I am thinking of rebasing and merging - rather than the usual squash-merge)

@lgarrison
Copy link
Collaborator

Yes, looks good! Either squash or rebase is fine with me, I don't understand the difference well enough to have a strong opinion!

@manodeep manodeep merged commit 23d1cc4 into master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants