-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip fixes #211
Conversation
Huh - weird! I would have thought that the #209 would have already accounted for the initial commits on this branch. |
Weird about the commits, maybe because we're "reusing" the same branch as the first PR? |
@lgarrison Thanks for fixing up the PR. Since the |
Here is an overview of what got changed by this pull request: Issues
======
+ Solved 1
Complexity decreasing per file
==============================
+ setup.py -3
See the complete overview on Codacy |
@lgarrison Is this okay to merge? (I am thinking of rebasing and merging - rather than the usual squash-merge) |
Yes, looks good! Either squash or rebase is fine with me, I don't understand the difference well enough to have a strong opinion! |
Still fixing #208