Simple Design Rule Check: no multiple drivers #130
Conversation
Conflicts: src/main/java/org/manifold/compiler/back/digital/Netlist.java
|
Not sure why the build has failed here -- something about Travis not being able to find a library. I'll check on this locally; if the Guava library version is no longer available, I'll commit a version bump. |
|
While I try to figure out this bug, can someone please checkout this branch, run the test cases, and tell me which, if any, fail? I am getting inconsistent results on test runs between two of my machines. |
|
I have fixed the test bug -- let's see if Travis will work this time. |
| import org.manifold.compiler.PortValue; | ||
|
|
||
|
|
||
| public class DRC_NoMultipleDrivers extends DesignRuleCheck { |
There was a problem hiding this comment.
Classes should not have underscores in their name. I'm surprised that this passed checkstyle.
There was a problem hiding this comment.
Instead, you might create a new namespace under back.digital or adopt a naming convention like
DesignRuleCheck->CheckDRC_NoMultipleDrivers->NoMultipleDriversCheck
There was a problem hiding this comment.
Ah, that was a warning from checkstyle. Okay, I'll refactor that to Check and FooCheck.
|
Looks great! Just some minor semantic issues that should be easy to address! 🐟 |
(the Schematic is always the place to go for those)
Design Rule Check: no multiple drivers
Addresses but does not completely deal with #119.