Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primitive nodes with attributes aren't put into the schematic with those attributes #70

Open
mtrberzi opened this issue Mar 20, 2015 · 3 comments
Labels

Comments

@mtrberzi
Copy link
Member

For example, register = primitive node (initialValue: Bool, resetActiveHigh: Bool, resetAsynchronous: Bool, clockActiveHigh: Bool, clock: digitalIn, reset: digitalIn, in: digitalIn) -> (out: digitalOut); only gets the digitalIn and digitalOut ports in the schematic, not the Bool attributes.

@mtrberzi mtrberzi added the bug label Mar 20, 2015
@maxqchen
Copy link
Contributor

I tried reproducing this straight from a schematic -> serialize path and couldn't. After adding a bool attribute to the node type and a bool value to the node value, I got this:

 "in_node_name": {
      "attributes": {
        "inNodeAttr": "Bool"
      },
      "ports": {
        "in_port_name": "digital_in"
      }
    }
...
"nIN": {
      "type": "in_node_name",
      "attributes": {
        "inNodeAttr": "true"
      },
      "portAttrs": {
        "in_port_name": {}
      }
    },

@mtrberzi
Copy link
Member Author

But is that in the schematic, or are you invoking the frontend? I think
this is a frontend problem.

On Thu, Mar 19, 2015 at 11:16 PM, Max Qitian Chen [email protected]
wrote:

I tried reproducing this straight from a schematic -> serialize path and
couldn't. After adding a bool attribute to the node type and a bool value
to the node value, I got this:

"in_node_name": {
"attributes": {
"inNodeAttr": "Bool"
},
"ports": {
"in_port_name": "digital_in"
}
}
...
"nIN": {
"type": "in_node_name",
"attributes": {
"inNodeAttr": "true"
},
"portAttrs": {
"in_port_name": {}
}
},


Reply to this email directly or view it on GitHub
#70 (comment)
.

@maxqchen
Copy link
Contributor

Yeah that was built from the schematic. Just confirming it wasn't a core issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants