Fix push handling #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2022
|
I don't know what I can do about the test failure based on the message:
It does not look like it is related to the code changes I did. |
|
It wouldn't surprise me if it's also broken on main 😢 I'll take a look |
|
There was a problem with the tests which I've fixed in: #33 |
|
That was a sneaky one ! |
The current default_transport value only works if one wants to push an image to docker.io. Here we change the default transport to be only about the schema. The image name is then parsed and normalized in the push method using the docker-image-py package.
This will allow for the image to work the same as the repo2docker image.
sgaist
force-pushed
the
fix_push_handling
branch
from
dedd21e
to
2320a3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request does mainly two things:
The former allows to run the tool with non
docker.ioregistries.The latter allows to clone private repositories as the repo2docker image does.