Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For Schema Extensions #68

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

MarkDordoy
Copy link
Contributor

This PR creates the models, data types and functions to perform CRUD operations on schema Extensions.

https://docs.microsoft.com/en-us/graph/api/resources/schemaextension?view=graph-rest-1.0

@manicminer manicminer force-pushed the md/support-schema-extensions branch from 4b205cb to ecd7e6f Compare June 24, 2021 22:54
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkDordoy thanks for the PR! I rebased and force-pushed your branch to make GitHub use the correct workflow configs, but this mostly LGTM. I just noticed that AdministrativeUnit is missing from the ExtensionSchemaTargetType constants?

msgraph/valuetypes.go Outdated Show resolved Hide resolved
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarkDordoy, this LGTM 🚀

@manicminer manicminer added this to the v0.19.0 milestone Jun 28, 2021
@manicminer manicminer added the enhancement New feature or request label Jun 28, 2021
@manicminer manicminer merged commit 3cf9c6d into manicminer:main Jun 28, 2021
@MarkDordoy MarkDordoy deleted the md/support-schema-extensions branch June 28, 2021 09:59
manicminer added a commit that referenced this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants