Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SkipExchangeInstantOn #275

Merged

Conversation

scott-doyland-burrows
Copy link
Contributor

Sdd SkipExchangeInstantOn as a pre-req to fixing hashicorp/terraform-provider-azuread#1315

@scott-doyland-burrows
Copy link
Contributor Author

Do I need to do anything else to get this merged?

@manicminer
Copy link
Owner

Hi @scott-doyland-burrows, thanks for opening this PR! Apologies for the delay in reviewing. This option doesn't seem to be documented - do you perhaps have any steps for getting this added to a group using official tooling (e.g. Entra Portal, M365 Admin Portal, PowerShell etc)?

@manicminer manicminer added enhancement New feature or request package/msgraph labels Mar 21, 2024
@scott-doyland-burrows
Copy link
Contributor Author

scott-doyland-burrows commented Mar 21, 2024

Hi,

You are correct, it isn't documented.

I have already raised a request to have the documentation updated.

But Microsoft have decided not to use GitHub for that particular documentation, so the best I could do was leave feedback on the documentation page and hope someone updates it - this is apparently the new and improved way of requesting documentation updates.

To test my PR worked I updated the terraform provider code to use the code in this PR and it did resolve the issue that prompted me to raise the linked issue for the terraform provider in the first place.

@manicminer manicminer added this to the v0.67.0 milestone Mar 25, 2024
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scott-doyland-burrows, I tested manually and this LGTM 👍

@manicminer manicminer merged commit a1f5121 into manicminer:main Mar 25, 2024
0 of 2 checks passed
manicminer added a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package/msgraph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants