Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Manager value for AccessReviewReviewerType #251

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

manicminer
Copy link
Owner

@manicminer manicminer added enhancement New feature or request package/msgraph labels Jul 26, 2023
@manicminer manicminer added this to the v0.63.0 milestone Jul 26, 2023
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from test failure 💾

@manicminer manicminer force-pushed the f/accessreviewtype-manager branch from e444d50 to cf9bdef Compare July 27, 2023 12:49
@manicminer
Copy link
Owner Author

Test failure looks to be a race condition with auto-approvals on access package assignment requests, unrelated to this change. Will fix separately due to complexity.

@manicminer manicminer merged commit 427b6a9 into main Jul 27, 2023
@manicminer manicminer deleted the f/accessreviewtype-manager branch July 27, 2023 13:00
manicminer added a commit that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package/msgraph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants