Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model SignInActivity to support non-interactive signin #237

Merged
merged 6 commits into from
Apr 3, 2023

Conversation

MarkDordoy
Copy link
Contributor

@MarkDordoy MarkDordoy commented Mar 30, 2023

Extends model to match documentation: https://learn.microsoft.com/en-us/graph/api/resources/signinactivity?view=graph-rest-beta

I also fixed the name locations test so checks go green.

@MarkDordoy MarkDordoy changed the title Update model to support non-interactive signin Update model SignInActivity to support non-interactive signin Mar 30, 2023
@manicminer manicminer added this to the v0.60.0 milestone Apr 3, 2023
@manicminer manicminer added enhancement New feature or request tests Includes tests package/msgraph labels Apr 3, 2023
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @MarkDordoy, this LGTM 👍

@manicminer manicminer merged commit df2836a into manicminer:main Apr 3, 2023
manicminer added a commit that referenced this pull request Apr 3, 2023
@MarkDordoy MarkDordoy deleted the md/update-model branch April 3, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package/msgraph tests Includes tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants