Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a function to create a group directly into an administrative unit #206

Merged
merged 8 commits into from
Jan 27, 2023
Merged

Conversation

SwissGipfel
Copy link
Contributor

@SwissGipfel SwissGipfel commented Jan 18, 2023

We'd like to provide an additional function on the AdministrativeUnitsClient which allows us to create group objects directly into an administrative unit, as documented on MS Docs.

This would enable managing group in an administrative unit without write permission on a whole tenant. As it states here, the permissions could be scoped only to the respective AU.
It would also enable to solve this issue on the terraform provider for azuread, as the provider uses this package as dependency.

SwissGipfel and others added 7 commits January 12, 2023 15:37
With c.CreateGroup it is now possible to create a group directly into an
AdministrativeUnit. This enables service principals to manage groups
inside an AdministrativeUnit without the need for global directory
permissions.
@SwissGipfel SwissGipfel marked this pull request as ready for review January 19, 2023 11:13
@manicminer manicminer added enhancement New feature or request package/msgraph labels Jan 19, 2023
@ccadruvi
Copy link
Contributor

Hey @manicminer, we couldn't reproduce the test failure, do you think the tests fail because of this addition?

@manicminer
Copy link
Owner

manicminer commented Jan 27, 2023

Hey @manicminer, we couldn't reproduce the test failure, do you think the tests fail because of this addition?

I think it was just some missing roles/permissions on our end, I believe I have fixed it now

Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SwissGipfel Thanks for this contribution! This LGTM 👍

@manicminer manicminer merged commit f6c2d35 into manicminer:main Jan 27, 2023
@manicminer manicminer added this to the v0.55.0 milestone Jan 27, 2023
manicminer added a commit that referenced this pull request Jan 27, 2023
kenchan0130 pushed a commit to kenchan0130/hamilton that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package/msgraph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants