Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groups fixes #143

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Groups fixes #143

merged 2 commits into from
Jan 28, 2022

Conversation

manicminer
Copy link
Owner

@manicminer manicminer commented Jan 28, 2022 •
edited
Loading

  • Group model: fix type for AllowExternalSenders field
  • Don't include the ID in the body when updating a group, as this prevents some Unified group fields from being updated

Test results (note: test runner is currently offline)

Screenshot 2022-01-28 at 00 51 34

@manicminer manicminer added bug Something isn't working package/msgraph labels Jan 28, 2022
@manicminer manicminer requested a review from katbyte January 28, 2022 00:49
@manicminer manicminer added this to the v0.40.1 milestone Jan 28, 2022
manicminer added a commit to hashicorp/terraform-provider-azuread that referenced this pull request Jan 28, 2022
@manicminer
REBASE: update Hamilton, depends on manicminer/hamilton#143
b744085
@manicminer manicminer mentioned this pull request Jan 28, 2022
Merged
katbyte
katbyte approved these changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌵

@manicminer manicminer merged commit 1f618bc into main Jan 28, 2022
@manicminer manicminer deleted the bugfix/groups-model-fixes branch January 28, 2022 02:06
manicminer added a commit that referenced this pull request Jan 28, 2022
@manicminer
v0.40.1
40a620f 
#143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
bug Something isn't working package/msgraph
Projects
None yet
Milestone
v0.40.1
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @katbyte