Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support role definitions and assignments via the unified role management endpoints #137

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Support role definitions and assignments via the unified role management endpoints #137

merged 3 commits into from
Jan 26, 2022

Conversation

manicminer
Copy link
Owner

Test results

Screenshot 2022-01-17 at 15 04 10

@manicminer manicminer added enhancement New feature or request package/msgraph labels Jan 17, 2022
@manicminer manicminer added this to the v0.40.0 milestone Jan 17, 2022
@manicminer manicminer force-pushed the feature/unified-role-management branch from 77e48a3 to b276e92 Compare January 24, 2022 13:14
@manicminer manicminer force-pushed the feature/unified-role-management branch from b276e92 to 427b3dd Compare January 26, 2022 09:40
koikonom
koikonom approved these changes Jan 26, 2022
View reviewed changes
Copy link

@koikonom koikonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jackofallops
jackofallops approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of super minor suggestions, but otherwise LGTM 👍

msgraph/role_assignments_test.go Outdated Show resolved Hide resolved
msgraph/role_definitions_test.go Outdated Show resolved Hide resolved
@manicminer manicminer merged commit 90b3e3c into main Jan 26, 2022
@manicminer manicminer deleted the feature/unified-role-management branch January 26, 2022 12:22
manicminer added a commit that referenced this pull request Jan 26, 2022
@manicminer
Changelog for #137
0711c35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackofallops jackofallops jackofallops approved these changes

@koikonom koikonom koikonom approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

@katbyte katbyte Awaiting requested review from katbyte

@stephybun stephybun Awaiting requested review from stephybun

@catriona-m catriona-m Awaiting requested review from catriona-m

Assignees
No one assigned
Labels
enhancement New feature or request package/msgraph
Projects
None yet
Milestone
v0.40.0
Development

Successfully merging this pull request may close these issues.
3 participants
@manicminer @koikonom @jackofallops