Helper func to load environment from metadata endpoint #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Intended as an equivalent to https://github.com/Azure/go-autorest/blob/master/autorest/azure/metadata_environment.go#L96-L141 - Not entirely useful as you need to supply the Resource Manager endpoint which is then re-used in the output struct, and the metadata endpoint does not currently provide an MS Graph endpoint - But it should work as a drop in replacement for the above linked helper function in go-autorest
manicminer
added a commit
to manicminer/azurerm-dalek
that referenced
this pull request
Dec 7, 2021
manicminer
requested review from
tombuildsstuff,
jackofallops,
katbyte and
koikonom
jackofallops
approved these changes
Dec 8, 2021
Comment on lines
+13
to
+14
| strategy: | ||
| fail-fast: true |
There was a problem hiding this comment.
You can remove this, it only affects jobs with a matrix configuration.
There was a problem hiding this comment.
Ah right, thanks! Will fix these in one go 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper func to generate environment configuration from metadata endpoint
Intended as an equivalent to https://github.com/Azure/go-autorest/blob/master/autorest/azure/metadata_environment.go#L96-L141
Not entirely useful as you need to supply the Resource Manager endpoint which is then re-used in the output struct, and the metadata endpoint does not currently provide an MS Graph endpoint
But it should work as a drop in replacement for the above linked helper function in go-autorest
Also fix an incorrect API ID for Key Vault