Resolved intermittent crash while seeking, added support for manifest files with CR-LF line breaks #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lines with unexpected whitespace prefix or suffix
neilrackett
changed the title
neilrackett
changed the title
|
thanks @neilrackett , I am not comfortable with a PR with so many things inside. |
| @@ -16,6 +17,8 @@ | |||
| <classEntry path="org.mangui.osmf.plugins.traits.HLSSeekTrait"/> | |||
| <classEntry path="org.mangui.osmf.plugins.traits.HLSTimeTrait"/> | |||
| <classEntry path="org.mangui.osmf.plugins.utils.ErrorManager"/> | |||
| <classEntry path="org.mangui.hls.loader.SubtitlesFragmentLoader"/> | |||
| <classEntry path="org.mangui.hls.utils.hls_internal"/> | |||
There was a problem hiding this comment.
Removed (leftover from another branch)
|
Hi @mangui, the PR started as a single item, but GitHub obviously includes all additional commits in the request, so I had to expand it -- I'll see what I can do to make PRs in more bite size chunks in the future (and won't commit SWF/SWC files). I've removed class references and |
# Conflicts: # bin/debug/flashls.swc # bin/debug/flashlsChromeless.swf # bin/debug/flashlsFlowPlayer.swf # bin/debug/flashlsOSMF.swc # bin/debug/flashlsOSMF.swf # bin/release/flashls.swc # bin/release/flashlsChromeless.swf # bin/release/flashlsFlowPlayer.swf # bin/release/flashlsOSMF.swc # bin/release/flashlsOSMF.swf
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
| <actionScriptProperties analytics="false" mainApplicationPath="flashls.as" projectUUID="e938451b-f4d1-4796-ba95-b9054fce71fa" version="11"> | |||
| <compiler additionalCompilerArguments="-locale=en_US -define+=CONFIG::LOGGING,false" autoRSLOrdering="true" copyDependentFiles="false" fteInMXComponents="false" generateAccessible="false" htmlExpressInstall="true" htmlGenerate="false" htmlHistoryManagement="false" htmlPlayerVersionCheck="true" includeNetmonSwc="false" outputFolderPath="bin" removeUnusedRSL="true" sourceFolderPath="src" strict="true" targetPlayerVersion="0.0.0" useApolloConfig="false" useDebugRSLSwfs="true" useFlashSDK="false" verifyDigests="true" warn="true"> | |||
| <compiler additionalCompilerArguments="-locale=en_US -define+=CONFIG::LOGGING,false" autoRSLOrdering="true" copyDependentFiles="false" fteInMXComponents="true" generateAccessible="false" htmlExpressInstall="true" htmlGenerate="false" htmlHistoryManagement="false" htmlPlayerVersionCheck="true" includeNetmonSwc="false" outputFolderPath="bin" removeUnusedRSL="true" sourceFolderPath="src" strict="true" targetPlayerVersion="0.0.0" useApolloConfig="false" useDebugRSLSwfs="true" useFlashSDK="false" verifyDigests="true" warn="false"> | |||
AudioTrackController.audioTracks using new Vector.<AltAudioTrack>() to prevent crash when reading HLS.audioTracks.length before audio is ready
| @@ -259,7 +259,7 @@ package org.mangui.hls { | |||
| public function set audioTrack(val : int) : void { | |||
| _audioTrackController.audioTrack = val; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
sorry I am a bit pedantic, but there are some useless whitespace there :-/
|
thanks for your contribution ... and patience ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following changes:
FragmentLoader.asnow checks for missing_fragPreviousdata while analysing PTS to prevent crashes caused by aTypeError: Error #1009: Cannot access a property or method of a null object referenceerror during seek operations, which we have been seeing intermittently with some VOD streamsnumAudioTracksgetter has been added toHLS.asas a convenient way of checking for the availability of alternative audio (for example when displaying a menu, etc)Manifest.as, and a newStringUtil.asclass added, to support manifest files that have been encoded with line breaks or other whitespace characters not in the expected Linux format, for example those using CR-LF line breaks instead of just LF