add support for CC 608/708 when there are multiple payloads inside sei packet #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unescape ‘Emulation Prevention' bytes for sei packet
|
thanks @steve6 |
| @@ -12,6 +12,8 @@ | |||
| /** Constants and utilities for the H264 video format. **/ | |||
| public class Nalu { | |||
|
|
|||
| private static var scratchEscapePositions:Array = new Array(10); | |||
There was a problem hiding this comment.
scratchEscapePositions is only used in unescapeStream(), IMHO it would be better to move it there as well.
There was a problem hiding this comment.
Yes, sounds better. Now is inside method.
| // Grow scratchEscapePositions to hold a larger number of positions. | ||
| scratchEscapePositions = scratchEscapePositions.concat(new Array(10)); | ||
| } | ||
| scratchEscapePositions[scratchEscapeCount++] = position; |
There was a problem hiding this comment.
you could use scratchEscapePositions.push(position), it will automatically adjust array length in case you exceed initial size
|
Hi @mangui. Is there anything else that needs to be done for the patch to be included? |
mangui
added a commit
that referenced
this pull request
Mar 9, 2016
add support for CC 608/708 when there are multiple payloads inside sei packet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test stream: http://demo.deltatre.it/cc-test/QualityLevels(1400000)/Manifest(video,format=m3u8-aapl).m3u8