Infer the Mock Type for Global Fetch #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f0a562a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2fc4cf6f.haruneko.pages.dev |
| Branch Preview URL: | https://fix-fetch-type-conflict.haruneko.pages.dev |
This reverts commit da5daae.
ronny1982
changed the title
|
That fix is indeed correcting the Github syntax check error caused by undici update, as checks are passed. After forcing modules updates on my end, for diagnosis purposes, i had the error, and with this fix i cant reproduce the error anymore. Now, i fail to see the consequences of this fix. All i can say is "that works". |
MikeZeDev
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for type incompatibility caused by nodejs/undici#1947
Always use the same type as
global.fetchfor our mock