add __int__, __hash__, __eq__ methods and missing annotations to Token, Local, and Argument classes #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n, Local, and Argument classes
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mike-hunhoff
requested changes
Mar 19, 2024
|
@akhilguruprasad22 lints are failing. Please be sure you've locally executed the linting steps outlined in the README. |
|
Noted, @mike-hunhoff . Will look into resolving this right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16 and additionally works towards #8
Chose to not declare these classes as subclasses of int due to possible issues regarding immutability of an instance and mainly compatibility, resulting in unpredictable behaviour (as these instances are expected to be valid substitutes for ints in operations which do not make sense for indices or tokens).