Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: improve parsing algorithm for rule generator feature editor #768

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

mike-hunhoff
Copy link
Collaborator

addresses #745 with improved yaml parsing.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@github-actions github-actions bot dismissed their stale review September 9, 2021 21:45

CHANGELOG updated or no update needed, thanks! 😄

Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me, you're the plugin wizard though 😉

@mike-hunhoff mike-hunhoff merged commit 71ce28d into master Sep 10, 2021
@mike-hunhoff mike-hunhoff deleted the explorer/fix/745 branch September 10, 2021 16:37
@williballenthin
Copy link
Collaborator

@jlepore-fe the plugin bug should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants