explorer: improve settings modification #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-hunhoff
changed the title
williballenthin
approved these changes
Mar 10, 2021
| @@ -567,15 +598,15 @@ def load_capa_rules(self): | |||
|
|
|||
| try: | |||
| # resolve rules directory - check self and settings first, then ask user | |||
| if not os.path.exists(settings.user.get("rule_path", "")): | |||
| if not os.path.exists(settings.user.get(CAPA_SETTINGS_RULE_PATH, "")): | |||
| settings.user[CAPA_SETTINGS_RULE_PATH], | ||
| settings.user[CAPA_SETTINGS_RULEGEN_AUTHOR], | ||
| settings.user[CAPA_SETTINGS_RULEGEN_SCOPE], | ||
| ) = dialog.get_values() |
There was a problem hiding this comment.
i can see this growing out of control in the future, though its fine for right now.
if we add further settings, lets abstract the return value into some settings object or at least a dictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #463.
created a new
Settingsbutton that, when clicked, opens a new dialog to modify the various capa explorer settings. displayed are the current values for each setting, or blank if the setting does not have a value yet. clickingOkapplies the settings, clickingCancelretains the previous values.