Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix backslash handling in string call arguments #2433

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix backslash handling in string call arguments #2433

merged 1 commit into from
Oct 3, 2024

Conversation

mr-tz
Copy link
Collaborator

@mr-tz mr-tz commented Oct 2, 2024

closes #2428

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@mr-tz mr-tz force-pushed the fix/vmray-string-call-args branch from fc40571 to f7e763e Compare October 2, 2024 16:51
@mr-tz mr-tz force-pushed the fix/vmray-string-call-args branch from f7e763e to 6d3b96f Compare October 2, 2024 16:54
@mr-tz mr-tz added this to the v7.4 milestone Oct 2, 2024
mike-hunhoff
mike-hunhoff approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable fix to me, thanks for the tests! LGTM 🚀

@mwilliams31 mwilliams31 mentioned this pull request Oct 2, 2024
Merged
@mr-tz mr-tz merged commit 030954d into master Oct 3, 2024
28 checks passed
@mr-tz mr-tz deleted the fix/vmray-string-call-args branch October 3, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwilliams31 mwilliams31 mwilliams31 approved these changes

@mike-hunhoff mike-hunhoff mike-hunhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.4
Development

Successfully merging this pull request may close these issues.

vmray: escape characters
3 participants
@mr-tz @mwilliams31 @mike-hunhoff