dnfile 0.15.0 changed API #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williballenthin
approved these changes
May 7, 2024
mr-tz
requested changes
May 10, 2024
@malwarefrank, can you address this as well, please? |
Closed
mr-tz
approved these changes
Jun 11, 2024
williballenthin
approved these changes
Jun 11, 2024
mike-hunhoff
approved these changes
Jun 11, 2024
ygasparis
pushed a commit
to ygasparis/capa
that referenced
this pull request
Jun 18, 2024
* dnfile 0.15.0 changed API * deduplicate str() calls and isort fixes * revert accidental change to imports ordering * add table variable annotation --------- Co-authored-by: Moritz <[email protected]> Co-authored-by: mr-tz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dnfile v0.15.0 contains a breaking change. The heap streams' .get() functions now return custom container objects instead of bytes.
I think I changed the necessary parts to keep same functionality, but am not definite. If necessary, feel free to close this PR and handle as you see fit. I just wanted to make it easier to integrate the breaking change.
Checklist