-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Refactor format in capa/features/extractors/dotnetfile.py
#2024
[ENH] Refactor format in capa/features/extractors/dotnetfile.py
#2024
Conversation
Signed-off-by: samadpls <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @samadpls . Please verify that the -vv
output from capa's standalone tool lists .NET
as the format in the metadata section by posting the output here. You can use one of the .NET
samples from capa/test-files
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased)
section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
@samadpls bump. Please let us know if you have any questions running capa locally against a test .NET file. Also, please add an entry to CHANGELOG.md with a short description of the PR when you get a chance. |
Signed-off-by: samadpls <[email protected]>
CHANGELOG updated or no update needed, thanks! 😄
Hello @mike-hunhoff , while setting up the locally im facing following issue capa -vv /media/samadpls/ubuntu/download/1c444ebeba24dcba8628b7dfe5fec7c6.exe_
ERROR:capa:[Errno 28] No space left on device: '/home/samadpls/.cache/capa'
ERROR:capa:Make sure your file directory contains properly formatted capa rules. You can download the standard collection of capa rules from https://github.com/mandiant/capa-rules/releases.
ERROR:capa:Please ensure you're using the rules that correspond to your major version of capa (7)
ERROR:capa:Or, for more details, see the rule set documentation here: https://github.com/mandiant/capa/blob/master/doc/rules.md |
Are you out of hard-drive space? |
@mike-hunhoff , Sorry for responding late; I was busy with academic workk.
full log
|
Hi @mr-tz , thanks for noticing. Yes, I noticed that my cache was full somehow, so I ran it on Windows and got the log |
Thank you for providing the output. Following the changes that you've made in this PR I'd expect capa's output to list
I'm unsure based solely on the output of command whether you're running the existing capa standalone tool or capa w/ the changes that you've made in this PR. Can you confirm that you have installed capa locally for development and that you are running capa with the changes that you've made in this PR? |
@mike-hunhoff, you were right. I was in the master branch and running the command. I apologize for the oversight capa 1c444ebeba24dcba8628b7dfe5fec7c6.exe_ -vv -r ./rules/
md5 1c444ebeba24dcba8628b7dfe5fec7c6
sha1 ebdec120fbbdbff28ebd6accc85d05f7ccabf461
sha256 a9f9e5a30cc858dc135ec428cdd68cb06143732e5c62c4dc4b359c8abc11d74b
path E:/extraproj/capa/1c444ebeba24dcba8628b7dfe5fec7c6.exe_
timestamp 2024-03-18 23:54:18.048229
capa version 7.0.1
os any
format dotnet
arch any
analysis static
extractor DnfileFeatureExtractor
base address global
rules E:/extraproj/capa/rules
function count 150
library function count 0
total feature count 4309
[ .... ] full log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking food @samadpls . One small change to add and we can merge 🚀
Co-authored-by: Mike Hunhoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Changed format order for .NET files
closes #2022
Checklist