Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a citation file to capa #2018

Merged
merged 12 commits into from
Mar 4, 2024
Merged

Conversation

Atlas-64
Copy link
Contributor

@Atlas-64 Atlas-64 commented Feb 29, 2024

Have added a citation file for capa, presently it's under the name "The FLARE Team", would require changes If team believes it should be substituted with the names of the core team members.

it closes issue #1929

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

.github/CITATION.cff Outdated Show resolved Hide resolved
.github/CITATION.cff Outdated Show resolved Hide resolved
.github/CITATION.cff Outdated Show resolved Hide resolved
.github/CITATION.cff Outdated Show resolved Hide resolved
.github/CITATION.cff Outdated Show resolved Hide resolved
@github-actions github-actions bot dismissed their stale review February 29, 2024 18:08

CHANGELOG updated or no update needed, thanks! 😄

Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add empty line at EOF and indent name, please, then should be good to go, thank you

.github/CITATION.cff Outdated Show resolved Hide resolved
.github/CITATION.cff Outdated Show resolved Hide resolved
@Atlas-64
Copy link
Contributor Author

Atlas-64 commented Mar 1, 2024

add empty line at EOF and indent name, please, then should be good to go, thank you

thanks to this I went down the rabbit hole behind the importance of a newline at the end of a file and how it causes issues if we don't add them , learnt something new pretty sweet!!

.github/CITATION.cff Outdated Show resolved Hide resolved
@Atlas-64
Copy link
Contributor Author

Atlas-64 commented Mar 4, 2024

@mr-tz would the above changes be fine

Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mr-tz mr-tz merged commit f6b0673 into mandiant:master Mar 4, 2024
25 checks passed
@mr-tz mr-tz mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants