Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elf: detect linux via GCC .ident directives #1928

Merged
merged 6 commits into from
Jan 11, 2024
Merged

elf: detect linux via GCC .ident directives #1928

merged 6 commits into from
Jan 11, 2024

Conversation

williballenthin
Copy link
Collaborator

addressing an OS detection miss on a private sample

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

yelhamer
yelhamer approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@yelhamer yelhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Thanks! :)

@williballenthin williballenthin merged commit 1dc72a3 into master Jan 11, 2024
27 checks passed
@williballenthin williballenthin deleted the more-elf-os-detection branch January 11, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yelhamer yelhamer yelhamer approved these changes

@mr-tz mr-tz Awaiting requested review from mr-tz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williballenthin @yelhamer