fix ints_to_bytes performance #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-hunhoff
added
enhancement
mike-hunhoff
commented
Aug 24, 2023
mike-hunhoff
commented
Aug 24, 2023
mike-hunhoff
commented
Aug 24, 2023
mike-hunhoff
commented
Aug 24, 2023
colton-gabertan
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Awesome refactoring & performance update. I'm sure that dramatically reduces runtime! Thanks @mike-hunhoff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently
int.to_bytesis horribly inefficient.Before changes
After changes:
This PR also contains small API changes to the Ghidra helper functions.