Check if caller.llil is None before accessing its properties #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import logging | ||
| import sys |
There was a problem hiding this comment.
Suggested change
| import logging | |
| import sys | |
| import sys | |
| import logging |
There was a problem hiding this comment.
I ended up removing the logging from imports since it is not used at all. It was only used when I troubleshoot the issue. And its usage was removed once I get it fixed
williballenthin
approved these changes
Apr 11, 2023
Oh yeah I am dummy I forgot about the formatting thing. I will fix it and ask you to merge it! |
It should be ready now. No surprise the BN related tests fail -- the action secrets are not available in builds triggered by a fork. |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1441
Checklist