Fix insn/byte extractor unit test #1337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
|
Thanks, I'll add the vivisect updates here. |
|
I force pushed moments ago (to fix my fat finger). You will wish to pull it
again to sync.
…On Wed, Mar 1, 2023 at 18:21 Moritz ***@***.***> wrote:
Thanks, I'll add the vivisect updates here.
—
Reply to this email directly, view it on GitHub
<#1337 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWRACE6ARZVTUSJQ4V5MDFDWZ4PKDANCNFSM6AAAAAAVL3DLQQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hm, seems I cannot update here due to permission issues. Can you check them or give me a hint on how to update? |
You should be able to fetch from our remote Vecto35/capa. But I will close this PR and create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in this pull request (PR). Include your motivation and context to help us review.
This PR fixes some unit tests that wrongly treat strings features as bytes features. It also fixes a bug in the IDA extractor that causes the old unit test to pass.
Please mention the issue your PR addresses (if any):
closes #1336 #1327