dotnet: emit namespace/class features for ldvirtftn/ldftn instructions #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
github-actions
bot
dismissed
their stale review
CHANGELOG updated or no update needed, thanks! 😄
mike-hunhoff
commented
Dec 19, 2022
Comment on lines
+60
to
+65
| if insn.opcode not in ( | ||
| OpCodes.Call, | ||
| OpCodes.Callvirt, | ||
| OpCodes.Jmp, | ||
| OpCodes.Newobj, | ||
| ): |
There was a problem hiding this comment.
tighten types (see ECMA VI.C.4.8)
Comment on lines
+99
to
+104
| if ih.inner.opcode not in ( | ||
| OpCodes.Call, | ||
| OpCodes.Callvirt, | ||
| OpCodes.Jmp, | ||
| OpCodes.Newobj, | ||
| ): |
There was a problem hiding this comment.
tighten types (see ECMA VI.C.4.8)
| @@ -116,7 +121,7 @@ def extract_insn_property_features(fh: FunctionHandle, bh, ih: InsnHandle) -> It | |||
| name: Optional[str] = None | |||
| access: Optional[str] = None | |||
|
|
|||
| if ih.inner.opcode in (OpCodes.Call, OpCodes.Callvirt, OpCodes.Jmp, OpCodes.Calli): | |||
| if ih.inner.opcode in (OpCodes.Call, OpCodes.Callvirt, OpCodes.Jmp): | |||
There was a problem hiding this comment.
tighten types (see ECMA VI.C.4.8)
mr-tz
approved these changes
Dec 20, 2022
williballenthin
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1117