Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render: display number zero vverbose #1097

Merged
merged 4 commits into from
Jul 8, 2022
Merged

render: display number zero vverbose #1097

merged 4 commits into from
Jul 8, 2022

Conversation

mike-hunhoff
Copy link
Collaborator

@mike-hunhoff mike-hunhoff commented Jul 7, 2022 •
edited
Loading

also, display number features as hex.

Screen Shot 2022-07-07 at 3 31 22 PM

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

github-actions[bot]
github-actions bot previously requested changes Jul 7, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@github-actions github-actions bot dismissed their stale review July 7, 2022 19:36

CHANGELOG updated or no update needed, thanks! 😄

mr-tz
mr-tz approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (see mypy though)

@mike-hunhoff mike-hunhoff merged commit 747eed4 into master Jul 8, 2022
@mike-hunhoff mike-hunhoff deleted the fix/display-number-zero branch July 8, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@williballenthin williballenthin Awaiting requested review from williballenthin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-hunhoff @mr-tz