-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet: support file/function scope class and namespace features #1030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased)
section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
CHANGELOG updated or no update needed, thanks! 😄
note: if merged we will emit for, e.g. - namespace: System.IO
- class: System.IO.File
- api: System.IO.File::Exists |
those features look great!
… On May 19, 2022, at 1:39 PM, Mike Hunhoff ***@***.***> wrote:
note: if merged we will emit for, e.g. System.IO.File::Exists, the following features:
- namespace: System.IO
- class: System.IO.File
- api: System.IO.File::Exists
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool, I have one suggestion around abstracting namespace, class, method into a class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool, thanks for the cleanup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome, thank you!
shall we merge @mike-hunhoff |
@williballenthin yes let's merge! |
see #1013 for additional context.
we emit both imported and user-defined class/namespace features allowing rules like:
we emit user-defined class/namespace features as this may be useful for writing rules that detect dotnet malware families.