Skip to content

Commit

Permalink
Restrict signature debug logging to vivisect backend
Browse files Browse the repository at this point in the history
Closes #1875
  • Loading branch information
acelynnzhang committed Apr 2, 2024
1 parent 7debc54 commit 16b0248
Showing 1 changed file with 22 additions and 17 deletions.
39 changes: 22 additions & 17 deletions capa/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -338,8 +338,9 @@ def handle_common_args(args):
- rules: file system path to rule files.
- signatures: file system path to signature files.
the following field may be added:
the following fields may be added:
- is_default_rules: if the default rules were used.
- is_default_signatures: if the default signatures were used.
args:
args: The parsed command line arguments from `install_common_args`.
Expand Down Expand Up @@ -432,25 +433,11 @@ def handle_common_args(args):

if hasattr(args, "signatures"):
if args.signatures == SIGNATURES_PATH_DEFAULT_STRING:
logger.debug("-" * 80)
logger.debug(" Using default embedded signatures.")
logger.debug(
" To provide your own signatures, use the form `capa.exe --signature ./path/to/signatures/ /path/to/mal.exe`."
)
logger.debug("-" * 80)

sigs_path = get_default_root() / "sigs"

if not sigs_path.exists():
logger.error(
"Using default signature path, but it doesn't exist. " # noqa: G003 [logging statement uses +]
+ "Please install the signatures first: "
+ "https://github.com/mandiant/capa/blob/master/doc/installation.md#method-2-using-capa-as-a-python-library."
)
raise IOError(f"signatures path {sigs_path} does not exist or cannot be accessed")
args.is_default_signatures = True
else:
sigs_path = Path(args.signatures)
logger.debug("using signatures path: %s", sigs_path)
args.is_default_signatures = False

args.signatures = sigs_path

Expand Down Expand Up @@ -702,6 +689,24 @@ def get_signatures_from_cli(args, input_format: str, backend: str) -> List[Path]
return []

try:
if args.is_default_signatures:
logger.debug("-" * 80)
logger.debug(" Using default embedded signatures.")
logger.debug(
" To provide your own signatures, use the form `capa.exe --signature ./path/to/signatures/ /path/to/mal.exe`."
)
logger.debug("-" * 80)

if not args.signatures.exists():
logger.error(
"Using default signature path, but it doesn't exist. " # noqa: G003 [logging statement uses +]
+ "Please install the signatures first: "
+ "https://github.com/mandiant/capa/blob/master/doc/installation.md#method-2-using-capa-as-a-python-library."
)
raise IOError(f"signatures path {args.signatures} does not exist or cannot be accessed")
else:
logger.debug("using signatures path: %s", args.signatures)

return capa.loader.get_signatures(args.signatures)
except IOError as e:
logger.error("%s", str(e))
Expand Down

0 comments on commit 16b0248

Please sign in to comment.