Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding connect-to-wmi-namespace-via-wbemlocator.yml #368

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

mike-hunhoff
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few comments

rule:
meta:
name: connect to WMI namespace via WbemLocator
namespace: collection/database/wmi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not necessarily collection

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very true - maybe add to host-interaction/wmi instead?

@mr-tz
Copy link
Collaborator

mr-tz commented May 7, 2021

bump, would love to get this in by the end of the week!

@Ana06
Copy link
Member

Ana06 commented May 7, 2021

Can we merge this after mandiant/capa#549 and #374? 🙏 This way this will be added to the CHANGELOG automatically.

@Ana06 Ana06 added dont merge Indicate a PR that is still being worked on and removed dont merge Indicate a PR that is still being worked on labels May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants