Migrates to use JepConfig stdout, stderr from setStream method

[ooprathamm]

Fixes #25

[ooprathamm]

I have made an attempt to remove the setStreams method and using JepConfig's std out, err .
The JepConfig methods excpect Outputstream objects but ghidra.app.plugin.core.interpreter.InterpreterConsole seems to return PrintWriters so I have used apache WriterOutputStream for this purpose

We can also look to adding a wrapper around PrintWriter objects rather than using WriterOutputStream

[mike-hunhoff]

Thank you @ooprathamm! Looks good so far - I left a couple of comments to address.

[mike-hunhoff]

Do we foresee any potential encoding issues by manually specifying UTF-8? e.g. Windows v Linux v Mac?

[ooprathamm]

As per the apache docs Charset is a required param and specifiying it explicitly does look out for possible encoding issues

[mike-hunhoff]

Understood! Is there any way for us to determine the encoding at runtime? e.g. is there a method we can call on out or err to get the encoding used and pass it to WriterOutputStream?

[ooprathamm]

I have added the method from java.nio.Charsets that provides us with the encoding used by the jvm (which should be the encoding used )

[mike-hunhoff]

Ok I think this looks good. Can you please include a screenshot of the unit tests passing in your environment w/ these changes? You can run this script from within Ghidra to kick off the tests.

[ooprathamm]

*Passing tests

I expected java.nio to be preinstalled, so rather than having it as dependency i have migrated to use System.getProperty() to get the encoding.

[mike-hunhoff]

*Passing tests I expected java.nio to be preinstalled, so rather than having it as dependency i have migrated to use System.getProperty() to get the encoding.

Can you run our example script in your environment? I'm not seeing print output in the Ghidrathon or Ghidra console windows.

[ooprathamm]

*Passing tests I expected java.nio to be preinstalled, so rather than having it as dependency i have migrated to use System.getProperty() to get the encoding.

Can you run our example script in your environment? I'm not seeing print output in the Ghidrathon or Ghidra console windows.

*Print Output of console window

[ooprathamm]

There seems to be something wrong with Ghidrathon. I will look into it.

[ooprathamm]

@mike-hunhoff Pardon for the late response, I got occupied by exams.
I was unable to triage the cause of broken interpreter window, any guidance could be useful.

[mike-hunhoff]

@mike-hunhoff Pardon for the late response, I got occupied by exams. I was unable to triage the cause of broken interpreter window, any guidance could be useful.

Were you able to isolate that changes introduced in this branch are the cause? Or do you believe something else may be causing the issue?

[ooprathamm]

@mike-hunhoff Pardon for the late response, I got occupied by exams. I was unable to triage the cause of broken interpreter window, any guidance could be useful.

Were you able to isolate that changes introduced in this branch are the cause? Or do you believe something else may be causing the issue?

yes, the changes are the cause.
I suspect that redirecting streams using jep is causing an overlapping(maybe) for the output stream for the script and the thread (because errors are printed but welcome and outputs aren't)

[ooprathamm]

@mike-hunhoff the broken interpreter window has been fixed.

• Run tests

*Run ghidrathon_example.py

*Interpreter Window

[mike-hunhoff]

looks great @ooprathamm , thank you!